Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pebble Refactor] Making indexing approval concurrent-safe #6374

Conversation

zhangchiqing
Copy link
Member

@zhangchiqing zhangchiqing commented Aug 19, 2024

Addressing review comments

Running concurrency test 100 times and passed:

go test --failfast --tags=relic  -run=TestApprovalStoreTwoDifferentApprovalsConcurrently -count=100
PASS
ok      github.com/onflow/flow-go/storage/pebble        7.535s

@zhangchiqing zhangchiqing force-pushed the leo/v0.33-pebble-storage-index-approval branch from 691d990 to a01d317 Compare August 19, 2024 23:49
@zhangchiqing zhangchiqing changed the base branch from v0.33 to leo/v0.33-pebble-storage-to-review August 20, 2024 03:40
@zhangchiqing zhangchiqing marked this pull request as ready for review August 20, 2024 03:40
@zhangchiqing zhangchiqing merged commit 8eb0f74 into leo/v0.33-pebble-storage-to-review Sep 13, 2024
51 checks passed
@zhangchiqing zhangchiqing deleted the leo/v0.33-pebble-storage-index-approval branch September 13, 2024 18:07
@zhangchiqing
Copy link
Member Author

Consolidate and merge all changes to leo/v0.33-pebble-storage-to-review. The changes in this PR can still be a reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant